Hi Leerho, Yes, Druid does not specify gpg plugin. It is better to create a sign profile for it.
Kind Regards, Furkan KAMACI On Tue, Jul 23, 2019 at 11:10 PM leerho <lee...@gmail.com> wrote: > Correction: Druid does NOT specify the gpg plugin. I will put it in a > "sign" profile like beam has it. > > On Tue, Jul 23, 2019 at 12:36 PM leerho <lee...@gmail.com> wrote: > >> Hi, >> Before I submit another RC, I want to understand what is causing your GPG >> problems. I have studied the POM files from Druid, Beam: 2.4, Pinot, and >> Dubbo. They each handle the GPG plugin differently: >> >> - Druid has it configured in the <build> section like I have it. >> - Beam puts it into a special "sign" profile. This only makes sense >> if you are driving Maven from scripts. >> - Pinot doesn't specify it at all (relies on the "apache-release" >> profile that does specify it) >> - Dubbo places it in a "release" profile. >> >> The GPG plugin is by default configured to run during the "verify" phase, >> which is just before the "install" phase, which makes sense. When you >> perform *mvn install,* maven is creating Jars from your sources and >> putting them into your .m2 repo. You naturally want to sign them at this >> point because the deploy phase will use these same jars plus signature >> files. >> >> Try running *mvn verify*. It should prompt you for a password ... but >> before entering your GPG pwd, you should see 6 artifacts (5 jars plus a pom >> file) in your /target directory. After entering you pwd, you should see >> each artifact with a *.asc signature. >> >> If you get your failure before the password prompt, then it may have to >> be something with your environment. I wonder if you have your >> .m2/settings.xml and .m2/settings-security.xml properly set up. >> >> If you can, send me he GPG error you are getting. >> >> I appreciate your working on this. >> >> Lee. >> >> >> >> >> On Tue, Jul 23, 2019 at 5:14 AM Furkan KAMACI <furkankam...@gmail.com> >> wrote: >> >>> Hi, >>> >>> It correctly checks whether gpg is running or not. However, gpg problem >>> is still persists. We should move it into another profile. >>> >>> Kind Regards, >>> Furkan KAMACI >>> >>> On Tue, Jul 23, 2019 at 3:57 AM leerho <lee...@gmail.com> wrote: >>> >>>> Did that fix the GPG issue? >>>> >>>> Thanks for the Pinot suggestion, I will study it. I have also been >>>> studying Druid and Beam for examples, but they both are quite complex >>>> deployments. >>>> >>>> Thank you!! >>>> Lee. >>>> >>>> On Mon, Jul 22, 2019 at 4:39 PM Furkan KAMACI <furkankam...@gmail.com> >>>> wrote: >>>> >>>>> Hi Leerho, >>>>> >>>>> To confirm gpg is running: >>>>> >>>>> env | grep gpg >>>>> >>>>> instead of >>>>> >>>>> env | grep GPG >>>>> >>>>> On the other hand, such plugin seems to be at another profile as you >>>>> say or signing could be handled in some other way. Could you check this >>>>> pom >>>>> files as an example: >>>>> >>>>> https://github.com/apache/incubator-druid/blob/master/pom.xml >>>>> https://github.com/apache/incubator-pinot/blob/master/pom.xml >>>>> >>>>> Kind Regards, >>>>> Furkan KAMACI >>>>> >>>>> On Tue, Jul 23, 2019 at 12:20 AM leerho <lee...@gmail.com> wrote: >>>>> >>>>>> Oh, the GPG problem could be that you need to start the GPG agent in >>>>>> your terminal at the very start, like this: >>>>>> >>>>>> # start gpg-agent in this env >>>>>> eval $(gpg-agent --daemon) >>>>>> >>>>>> # To confirm that the GPG agent is running: >>>>>> env | grep GPG >>>>>> >>>>>> However, I don't think the GPG plug-in should be in the main POM, it >>>>>> needs to be in a release profile, I think. >>>>>> >>>>>> (I am not a Maven expert. I have asked for Maven help but none seems >>>>>> to be forthcoming :( ) >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> On Mon, Jul 22, 2019 at 2:14 PM leerho <lee...@gmail.com> wrote: >>>>>> >>>>>>> I understand the [self-equals] error ... it is a false positive, >>>>>>> which I can eliminate with an annotation. >>>>>>> >>>>>>> I don't understand the GPG plugin issue. >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> On Mon, Jul 22, 2019 at 1:30 PM Furkan KAMACI < >>>>>>> furkankam...@gmail.com> wrote: >>>>>>> >>>>>>>> Hi Leerho, >>>>>>>> >>>>>>>> For the people who get same error, I've deleted related version >>>>>>>> from ~/.m2 folder and installed the project code. Current situation: >>>>>>>> >>>>>>>> 1) I get an error: >>>>>>>> >>>>>>>> Failed to execute goal >>>>>>>> org.apache.maven.plugins:maven-gpg-plugin:1.6:sign >>>>>>>> (sign-release-artifacts) >>>>>>>> on project datasketches-memory: Exit code: 2 >>>>>>>> >>>>>>>> I've skipped it with adding that configuration: >>>>>>>> >>>>>>>> <configuration> >>>>>>>> <skip>true</skip> >>>>>>>> </configuration> >>>>>>>> >>>>>>>> What maybe the problem? >>>>>>>> >>>>>>>> 2) I can compile the code with m2e profile >>>>>>>> >>>>>>>> 3) I get that error with strict profile: >>>>>>>> >>>>>>>> Failed to execute goal >>>>>>>> org.apache.maven.plugins:maven-compiler-plugin:3.7.0:testCompile >>>>>>>> (default-testCompile) on project datasketches-memory: Compilation >>>>>>>> failure: >>>>>>>> Compilation failure: >>>>>>>> [ERROR] >>>>>>>> incubator-datasketches-memory/src/test/java/org/apache/datasketches/memory/WritableMemoryTest.java:[88,31] >>>>>>>> [SelfEquals] Testing an object for equality with itself will always be >>>>>>>> true. >>>>>>>> [ERROR] (see http://errorprone.info/bugpattern/SelfEquals) >>>>>>>> >>>>>>>> Kind Regards, >>>>>>>> Furkan KAMACI >>>>>>>> >>>>>>>> On Mon, Jul 22, 2019 at 11:28 PM leerho <lee...@gmail.com> wrote: >>>>>>>> >>>>>>>>> Ok. I withdraw this RC1 and will resubmit an RC2 that should pass >>>>>>>>> the strict test as well. This should take less than an hour. >>>>>>>>> >>>>>>>>> Lee. >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> On Mon, Jul 22, 2019 at 1:09 PM leerho <lee...@gmail.com> wrote: >>>>>>>>> >>>>>>>>>> Ah yes. It turns out that the strict profile detects a false >>>>>>>>>> positive and fails :(. And there is no way to suppress that false >>>>>>>>>> positive with annotation. >>>>>>>>>> At line 100 in XxHash64Test.java, the multiplication >>>>>>>>>> (0x9C90005B80000000L * 2) is intentionally meant to overflow. The >>>>>>>>>> strict >>>>>>>>>> test, however, catches the overflow and declares it an error. >>>>>>>>>> I can rewrite it to eliminate the overflow, but it will make the >>>>>>>>>> test harder to understand. >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On Mon, Jul 22, 2019 at 12:33 PM leerho <lee...@gmail.com> wrote: >>>>>>>>>> >>>>>>>>>>> Odd. Maven-jar-plugin 3.1.2 clearly exists on Maven Central: >>>>>>>>>>> https://search.maven.org/search?q=g:org.apache.maven.plugins%20AND%20a:maven-jar-plugin&core=gav >>>>>>>>>>> . >>>>>>>>>>> >>>>>>>>>>> Overriding the Apache Parent Pom is always an option and should >>>>>>>>>>> work (At least it does for me.). >>>>>>>>>>> >>>>>>>>>>> But sometimes when I experience problems like this I either run *mvn >>>>>>>>>>> install* or *mvn package*. This will force all dependencies >>>>>>>>>>> into your local .m2 repository. >>>>>>>>>>> >>>>>>>>>>> I'm not sure why you are having this issue, nevertheless, using >>>>>>>>>>> 3.1.0 should also work. >>>>>>>>>>> >>>>>>>>>>> *Profiles:* >>>>>>>>>>> There are only 2 profiles: >>>>>>>>>>> >>>>>>>>>>> - The *m2e* profile exists only to: >>>>>>>>>>> Ignore nuisance warning from Apache parent plugin: >>>>>>>>>>> "maven-remote-resources-plugin (goal "process") is ignored by >>>>>>>>>>> m2e". This >>>>>>>>>>> also should fix the Maven warning that it can't find the >>>>>>>>>>> lifecycle-mapping >>>>>>>>>>> jar. So you can ignore this one. >>>>>>>>>>> - The *strict* profile runs the org.codehaus.plexus : >>>>>>>>>>> plexus-compiler-javac-errorprone plugin. This compiler is more >>>>>>>>>>> sensitive >>>>>>>>>>> to potential coding errors. You can run this as an option. I >>>>>>>>>>> always do >>>>>>>>>>> prior to a release. >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> On Mon, Jul 22, 2019 at 11:38 AM Furkan KAMACI < >>>>>>>>>>> furkankam...@gmail.com> wrote: >>>>>>>>>>> >>>>>>>>>>>> Hi Leerho, >>>>>>>>>>>> >>>>>>>>>>>> Thanks for the links! >>>>>>>>>>>> >>>>>>>>>>>> I cannot compile the source code. I get that error: >>>>>>>>>>>> >>>>>>>>>>>> Plugin org.apache.maven.plugins:maven-jar-plugin:3.1.2 or one >>>>>>>>>>>> of its dependencies could not be resolved: Failure to find >>>>>>>>>>>> org.apache.maven.plugins:maven-jar-plugin:jar:3.1.2 in >>>>>>>>>>>> https://repo.maven.apache.org/maven2 was cached in the local >>>>>>>>>>>> repository, resolution will not be reattempted until the update >>>>>>>>>>>> interval of >>>>>>>>>>>> central has elapsed or updates are forced >>>>>>>>>>>> >>>>>>>>>>>> So, I've checked that this dependency extends the version at >>>>>>>>>>>> Apache Repo. I've set the version as 3.1.0 and it has started to >>>>>>>>>>>> compile. >>>>>>>>>>>> Do you have any idea about it? >>>>>>>>>>>> >>>>>>>>>>>> On the other hand, should I activate a profile while compiling >>>>>>>>>>>> and testing source code? >>>>>>>>>>>> >>>>>>>>>>>> Kind Regards, >>>>>>>>>>>> Furkan KAMACI >>>>>>>>>>>> >>>>>>>>>>>> On Mon, Jul 22, 2019 at 8:34 PM leerho <lee...@gmail.com> >>>>>>>>>>>> wrote: >>>>>>>>>>>> >>>>>>>>>>>>> If you are interested, the documentation for the DataSketches >>>>>>>>>>>>> Memory component is part of the website. >>>>>>>>>>>>> >>>>>>>>>>>>> Specifically: >>>>>>>>>>>>> - >>>>>>>>>>>>> https://datasketches.github.io/docs/Memory/MemoryPackage.html >>>>>>>>>>>>> - >>>>>>>>>>>>> https://datasketches.github.io/docs/Memory/MemoryPerformance.html >>>>>>>>>>>>> >>>>>>>>>>>>> Lee. >>>>>>>>>>>>> >>>>>>>>>>>>> On Mon, Jul 22, 2019 at 10:28 AM leerho <lee...@gmail.com> >>>>>>>>>>>>> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>>> A 500 error is a malformed link or some internal GitHub >>>>>>>>>>>>>> server error .... I don't get that error when just clicking on >>>>>>>>>>>>>> the link. >>>>>>>>>>>>>> >>>>>>>>>>>>>> When exactly are you getting that error message? >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> On Mon, Jul 22, 2019 at 9:08 AM Furkan KAMACI < >>>>>>>>>>>>>> furkankam...@gmail.com> wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>>> Hi Leerho, >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> GitHub throws a 500 error for this link: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> https://github.com/apache/incubator-datasketches-memory >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> is that usual? >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Kind Regards, >>>>>>>>>>>>>>> Furkan KAMACI >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> On Sun, Jul 21, 2019 at 9:33 PM leerho <lee...@gmail.com> >>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Note also that when running the test suite, you might get >>>>>>>>>>>>>>>> the following message: >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> SLF4J: Failed to load class >>>>>>>>>>>>>>>> "org.slf4j.impl.StaticLoggerBinder". >>>>>>>>>>>>>>>> SLF4J: Defaulting to no-operation (NOP) logger >>>>>>>>>>>>>>>> implementation >>>>>>>>>>>>>>>> SLF4J: See >>>>>>>>>>>>>>>> http://www.slf4j.org/codes.html#StaticLoggerBinder for >>>>>>>>>>>>>>>> further details. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> This is normal. It just indicates that in your >>>>>>>>>>>>>>>> environment, you do not have a logger in your class-path so >>>>>>>>>>>>>>>> the default >>>>>>>>>>>>>>>> logger of a *no-op* is used instead. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> On Sat, Jul 20, 2019 at 8:52 AM leerho <lee...@gmail.com> >>>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> The DataSketches-memory component is pure Java and is >>>>>>>>>>>>>>>>> structured as a Maven project. You must compile using JDK 8. >>>>>>>>>>>>>>>>> The simplest >>>>>>>>>>>>>>>>> way is to import the unzipped code into Eclipse or equivalent >>>>>>>>>>>>>>>>> IDE as a >>>>>>>>>>>>>>>>> Maven Project. There is one run-time dependency and, of >>>>>>>>>>>>>>>>> course, a number >>>>>>>>>>>>>>>>> of test and Maven plugin dependencies, all of which will be >>>>>>>>>>>>>>>>> resolved by >>>>>>>>>>>>>>>>> your IDE. >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> This component is a set of low-level library functions >>>>>>>>>>>>>>>>> that is used by the other DataSketches components. It has no >>>>>>>>>>>>>>>>> user >>>>>>>>>>>>>>>>> interface so the only thing you can do is compile and run the >>>>>>>>>>>>>>>>> unit tests. >>>>>>>>>>>>>>>>> Unless, of course, you are interested in the actual functions >>>>>>>>>>>>>>>>> of the Memory >>>>>>>>>>>>>>>>> and are willing to write code that calls the Memory functions. >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> This particular component has been split out from the rest >>>>>>>>>>>>>>>>> of the DataSketches code because there have been a number of >>>>>>>>>>>>>>>>> requests from >>>>>>>>>>>>>>>>> folks that are interested in these high-performance functions >>>>>>>>>>>>>>>>> independently >>>>>>>>>>>>>>>>> of the remainder of the DataSketches library. >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Lee. >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> On Fri, Jul 19, 2019 at 7:24 PM Liang Chen < >>>>>>>>>>>>>>>>> chenliang...@apache.org> wrote: >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> Hi >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> Please provide the build guide, how to compile source >>>>>>>>>>>>>>>>>> code. >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> Regards >>>>>>>>>>>>>>>>>> Liang >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> leerho <lee...@gmail.com> 于2019年7月20日周六 上午10:05写道： >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> > Hello Apache DataSketches Community, >>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>> > 1. This is a call for vote to release Apache >>>>>>>>>>>>>>>>>> DataSketches-memory version: >>>>>>>>>>>>>>>>>> > 1.0.0-incubating-RC1 >>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>> > NOTE 1: This is one component of the DataSketches >>>>>>>>>>>>>>>>>> library which needs to >>>>>>>>>>>>>>>>>> > be released first as other >>>>>>>>>>>>>>>>>> > repositories have a dependency on this one. Once this >>>>>>>>>>>>>>>>>> is released, the >>>>>>>>>>>>>>>>>> > other components of the library >>>>>>>>>>>>>>>>>> > will be able to be released. >>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>> > NOTE 2: All of the code has been properly refactored >>>>>>>>>>>>>>>>>> with >>>>>>>>>>>>>>>>>> > "org.apache.datasketches...". >>>>>>>>>>>>>>>>>> > All source files have the proper Apache license and >>>>>>>>>>>>>>>>>> have been checked with >>>>>>>>>>>>>>>>>> > the Maven Rat Plugin. >>>>>>>>>>>>>>>>>> > The code passes all tests with a coverage of > 98%. >>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>> > 2. The release candidate: >>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>> https://dist.apache.org/repos/dist/dev/incubator/datasketches/memory/1.0.0-incubating-RC1/apache-datasketches-memory-1.0.0-incubating-RC1-src.zip >>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>> > 3. Source repository: >>>>>>>>>>>>>>>>>> > https://github.com/apache/incubator-datasketches-memory >>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>> > Git Tag for this release: >>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>> https://github.com/apache/incubator-datasketches-memory/tree/1.0.0-incubating-RC1 >>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>> > Git HashId for this release starts with: 966f9bf >>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>> > The artifacts have been signed with --keyid-format >>>>>>>>>>>>>>>>>> SHORT : 8CD4A902 >>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>> > 4. Repository: dist.apache.org repository: >>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>> > The public signing key can be found in the KEYS file: >>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>> https://dist.apache.org/repos/dist/dev/incubator/datasketches/KEYS >>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>> > Upon acceptance, the above artifacts will be deployed >>>>>>>>>>>>>>>>>> into the official >>>>>>>>>>>>>>>>>> > Apache release repository: >>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>> https://dist.apache.org/repos/dist/release/incubator/datasketches/memory/ >>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>> > 5. Repository: Maven Central (repository.apache.org): >>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>> > Upon acceptance the jar artifacts will be generated >>>>>>>>>>>>>>>>>> from the source >>>>>>>>>>>>>>>>>> > repository and deployed >>>>>>>>>>>>>>>>>> > to the Apache Maven Central staging repository: >>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>> https://repository.apache.org/content/groups/staging/org/apache/datasketches/memory/ >>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>> > And then released into >>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>> https://repository.apache.org/content/repositories/releases/datasketches/memory/ >>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>> > 6. The vote will be open for at least 72 hours or until >>>>>>>>>>>>>>>>>> necessary number >>>>>>>>>>>>>>>>>> > of votes are reached. >>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>> > Please vote accordingly: >>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>> > [ ] +1 approve >>>>>>>>>>>>>>>>>> > [ ] +0 no opinion >>>>>>>>>>>>>>>>>> > [ ] -1 disapprove with the reason >>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>> > Thanks, >>>>>>>>>>>>>>>>>> > The Apache DataSketches Team >>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>
