+1 (binding) I checked: - checksum and signature of both main distribution artifact and pgxn convenience package - NOTICE and LICENSE seem correct - Built in docker on both Mac and Linux - Generated sample data and successfully ran the examples in the readme
Not sure if the datasketches.control file needs a full header. I think I'd vote yes as long as the format allows it. The file seems to start comment lines with a # but I don't know if there's a specific format requirement of only one comment line. META.json can't support that. jon On Fri, Nov 17, 2023 at 6:55 PM Alexander Saydakov <[email protected]> wrote: > Dear Apache DataSketches PMC and Community, > > > This is a call for vote to release Apache DataSketches-postgresql version > 1.7.0-rc2 > > > This is an extension for PostgreSQL database based on the Apache > DataSketches-cpp core library. > > Changes since rc1: > > - Added upgrade script from 1.6.0 to 1.7.0 to Makefile for installation > > Changes in this release since 1.6.0: > > - Based on the latest datasketches-cpp 5.0.0 (upgraded from 4.1.0) > - fixed slowness in Theta intersection > - fixed incompatibility of serialized empty frequent items sketches > with Java > > Source repository: https://github.com/apache/datasketches-postgresql > > > Git tag for this release candidate: > https://github.com/apache/datasketches-postgresql/tree/1.7.0-rc2 > > > Git HashId for this release is: 91cbd54c70abba9bf2487c33006e35cfd32ed171 > > > The public signing key can be found in the KEYS file: > https://dist.apache.org/repos/dist/dev/datasketches/KEYS > > > The artifacts have been signed with key: 68486114A8E8B4E0 2019-08-20 > Alexander Saydakov (CODE SIGNING KEY) <[email protected]> > > > The release candidate repository: > https://dist.apache.org/repos/dist/dev/datasketches/postgresql/1.7.0-rc2 > > > How to build and install: > https://github.com/apache/datasketches-postgresql/blob/1.7.0-rc2/README.md > > > This letter will be published on dev@ and remain open for at least 72 > hours (excluding weekends and holidays), and until at least 3 (+1) PMC > votes or a majority of (+1) PMC votes are acquired. Anyone in the > community can vote. > > Please vote accordingly: > > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove with the reason > > > Thank you. > Alexander Saydakov > > <[email protected]>[email protected] >
