+1 checked license and readme installed using the docker commands created the extension and ran the test query from the first section
nb. I could run the docker example query. I assume that the output I got was correct but there is no expected output in the repo. On Thu, 14 Dec 2023 at 12:44, David Cromberge <[email protected]> wrote: > +1 > > The following checks passed: > - LICENCE and README present > - make and install using cpp core 5.0.0 > - created extension and ran test queries > - checked sha and signatures > > David > > On 2023/12/01 00:28:24 Lee Rhodes wrote: > > +1(binding) > > > > I checked > > - cloned the code at the specified git tag > > - make //worked ok but got two warnings : > > - *boost/boost/math/tools/config.hpp:23:6: **warning: **"The minimum > > language standard to use Boost.Math will be C++14 starting in July 2023 > > (Boost 1.82 release)"* //I linked to boost 1.82.0, and using C++11, but > it > > worked ok. > > - *ld: warning: -multiply_defined is obsolete* > > I ignored these > > - make install //it worked just fine. > > - Verified with the test database and got the printout as per > instructions. > > > > > > > > On Mon, Nov 27, 2023 at 5:59 PM Jon Malkin <[email protected]> wrote: > > > > > To be clear, my vote is a +1 regardless of whether we add a header to > that > > > file in the future. I do not consider it a blocker for this release. > > > > > > jon > > > > > > On Mon, Nov 27, 2023 at 5:40 PM Jon Malkin <[email protected]> > wrote: > > > > > >> +1 (binding) > > >> > > >> I checked: > > >> - checksum and signature of both main distribution artifact and pgxn > > >> convenience package > > >> - NOTICE and LICENSE seem correct > > >> - Built in docker on both Mac and Linux > > >> - Generated sample data and successfully ran the examples in the > readme > > >> > > >> Not sure if the datasketches.control file needs a full header. I think > > >> I'd vote yes as long as the format allows it. The file seems to start > > >> comment lines with a # but I don't know if there's a specific format > > >> requirement of only one comment line. META.json can't support that. > > >> > > >> jon > > >> > > >> On Fri, Nov 17, 2023 at 6:55 PM Alexander Saydakov > > >> <[email protected]> wrote: > > >> > > >>> Dear Apache DataSketches PMC and Community, > > >>> > > >>> > > >>> This is a call for vote to release Apache DataSketches-postgresql > > >>> version 1.7.0-rc2 > > >>> > > >>> > > >>> This is an extension for PostgreSQL database based on the Apache > > >>> DataSketches-cpp core library. > > >>> > > >>> Changes since rc1: > > >>> > > >>> - Added upgrade script from 1.6.0 to 1.7.0 to Makefile for > > >>> installation > > >>> > > >>> Changes in this release since 1.6.0: > > >>> > > >>> - Based on the latest datasketches-cpp 5.0.0 (upgraded from 4.1.0) > > >>> - fixed slowness in Theta intersection > > >>> - fixed incompatibility of serialized empty frequent items > > >>> sketches with Java > > >>> > > >>> Source repository: > https://urldefense.com/v3/__https://github.com/apache/datasketches-postgresql__;!!Op6eflyXZCqGR5I!AtleI6QoTRKc1PVt56y35QiuNxTyBZCJkrqYpI9WWvTCm42WxyRSUQ95WS0ge6lXRID3J6W5pKu2IiQznxFQ9DBIJndcKg$ > > >>> > > >>> > > >>> Git tag for this release candidate: > > >>> > https://urldefense.com/v3/__https://github.com/apache/datasketches-postgresql/tree/1.7.0-rc2__;!!Op6eflyXZCqGR5I!AtleI6QoTRKc1PVt56y35QiuNxTyBZCJkrqYpI9WWvTCm42WxyRSUQ95WS0ge6lXRID3J6W5pKu2IiQznxFQ9DC2lzn13g$ > > >>> > > >>> > > >>> Git HashId for this release is: > 91cbd54c70abba9bf2487c33006e35cfd32ed171 > > >>> > > >>> > > >>> The public signing key can be found in the KEYS file: > > >>> > https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/KEYS__;!!Op6eflyXZCqGR5I!AtleI6QoTRKc1PVt56y35QiuNxTyBZCJkrqYpI9WWvTCm42WxyRSUQ95WS0ge6lXRID3J6W5pKu2IiQznxFQ9DAzU0aLXw$ > > >>> > > >>> > > >>> The artifacts have been signed with key: 68486114A8E8B4E0 2019-08-20 > > >>> Alexander Saydakov (CODE SIGNING KEY) <[email protected]> > > >>> > > >>> > > >>> The release candidate repository: > > >>> > https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/postgresql/1.7.0-rc2__;!!Op6eflyXZCqGR5I!AtleI6QoTRKc1PVt56y35QiuNxTyBZCJkrqYpI9WWvTCm42WxyRSUQ95WS0ge6lXRID3J6W5pKu2IiQznxFQ9DCjbJA7Gg$ > > >>> > > >>> > > >>> How to build and install: > > >>> > https://urldefense.com/v3/__https://github.com/apache/datasketches-postgresql/blob/1.7.0-rc2/README.md__;!!Op6eflyXZCqGR5I!AtleI6QoTRKc1PVt56y35QiuNxTyBZCJkrqYpI9WWvTCm42WxyRSUQ95WS0ge6lXRID3J6W5pKu2IiQznxFQ9DCQCRKS0g$ > > >>> > > >>> > > >>> This letter will be published on dev@ and remain open for at least > 72 > > >>> hours (excluding weekends and holidays), and until at least 3 (+1) > PMC > > >>> votes or a majority of (+1) PMC votes are acquired. Anyone in the > > >>> community can vote. > > >>> > > >>> Please vote accordingly: > > >>> > > >>> [ ] +1 approve > > >>> [ ] +0 no opinion > > >>> [ ] -1 disapprove with the reason > > >>> > > >>> > > >>> Thank you. > > >>> Alexander Saydakov > > >>> > > >>> <[email protected]>[email protected] > > >>> > > >> > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
