jmalkin opened a new pull request, #23: URL: https://github.com/apache/datasketches-python/pull/23
Not super excited with how import_arrays() is added currently -- it seems like it's supposed to be part of a very short main() but we don't really have that in this case. Expecting I'll need to make additional changes here. Vector of KLL might have some very slight performance regressions. I tried changing the get_index code back to std::vector and that didn't actually help. My current guess is that the more generic nanobind matrix data model has an additional cost. Whether we think there's enough other benefit to justify this will be the key deciding factor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
