jmalkin commented on PR #23: URL: https://github.com/apache/datasketches-python/pull/23#issuecomment-1879129894
@c-dickens I addressed the 50% degradation in density, and after trying a bunch of stuff in vector_of_kll it's, well, still a small drop in performance. But certainly for our classic sketches it's a win. As noted, this is doing all the iteration in python, which we know is slow, but it seems to indicate that nanobind's python<->C++ interface really does provide less overhead for non-matrix/vector types. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
