leerho commented on PR #685: URL: https://github.com/apache/datasketches-java/pull/685#issuecomment-3363372840
Lots of cleanup after Sketches class was removed. Fixed some very bad assumptions with heapify(...) and wrap(...) where if the simple call was made, i.e., heapify(seg) not only was the default update seed assumed (this is normal), but the seed hash was not checked! Yikes! Same thing with wrap(...). I'm not sure how that ever happened, but it is now fixed. I think a lot of that was associated with the old SerVer 1 and 2 stuff. This also fixed the squirrelly testing that somehow figured that the above was ok!?! Also added some checks when reading the preamble of a user's input segment -- made sure that the segment was at least large enough to hold the full preamble. This is a big PR. I would suggest reviewers go through the changes commit by commit, rather than the whole thing at once. I haven't done the class name changes yet. I will do that in a PR all by itself because it doesn't involve any logic changes, just the names of some classes -- And that should be easier to review by itself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
