leerho commented on code in PR #685:
URL: https://github.com/apache/datasketches-java/pull/685#discussion_r2402829239
##########
src/main/java/org/apache/datasketches/theta/UpdateSketch.java:
##########
@@ -142,15 +157,23 @@ public static UpdateSketch heapify(final MemorySegment
srcSeg, final long expect
@Override
public CompactSketch compact(final boolean dstOrdered, final MemorySegment
dstWSeg) {
- return componentsToCompact(getThetaLong(), getRetainedEntries(true),
getSeedHash(), isEmpty(),
- false, false, dstOrdered, dstWSeg, getCache());
+ return componentsToCompact(
+ getThetaLong(),
+ getRetainedEntries(true),
+ getSeedHash(),
+ isEmpty(),
+ false, //is src compact
+ false, //is src ordered
+ dstOrdered,
+ dstWSeg,
+ getCache());
}
@Override
public int getCompactBytes() {
final int preLongs = getCompactPreambleLongs();
final int dataLongs = getRetainedEntries(true);
- return (preLongs + dataLongs) << 3;
+ return preLongs + dataLongs << 3;
Review Comment:
Fixed!
##########
src/test/java/org/apache/datasketches/theta/UpdateSketchTest.java:
##########
@@ -211,12 +210,12 @@ public void checkIsResizeFactorIncorrect() {
public void checkCompactOpsMemorySegmentToCompact() {
MemorySegment skwseg, cskwseg1, cskwseg2, cskwseg3;
CompactSketch csk1, csk2, csk3;
- int lgK = 6;
- UpdateSketch sk =
Sketches.updateSketchBuilder().setLogNominalEntries(lgK).build();
- int n = 1 << (lgK + 1);
+ final int lgK = 6;
+ final UpdateSketch sk =
UpdateSketch.builder().setLogNominalEntries(lgK).build();
+ final int n = 1 << lgK + 1;
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
