leerho commented on code in PR #685:
URL: https://github.com/apache/datasketches-java/pull/685#discussion_r2402831281
##########
src/main/java/org/apache/datasketches/tuple/arrayofdoubles/DirectArrayOfDoublesQuickSelectSketch.java:
##########
@@ -144,15 +125,7 @@ private static final boolean checkMemorySegment(
DirectArrayOfDoublesQuickSelectSketch(
final MemorySegment seg,
final long seed) {
- this(checkSerVer(seg), seg, seed);
- //SpotBugs CT_CONSTRUCTOR_THROW is false positive.
- //this construction scheme is compliant with SEI CERT Oracle Coding
Standard for Java / OBJ11-J
- }
-
- private DirectArrayOfDoublesQuickSelectSketch(
- @SuppressWarnings("unused") final boolean secure, //required part of
Finalizer Attack prevention
- final MemorySegment seg,
- final long seed) {
+ checkSerVer(seg);
super(seg.get(JAVA_BYTE, NUM_VALUES_BYTE), seed);
Review Comment:
Copilot is out-of-date. As of Java 25, super() no longer has to be the
first statement of a constructor. And it compiles just fine!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
