proost commented on code in PR #120:
URL: https://github.com/apache/datasketches-go/pull/120#discussion_r2788855820
##########
sampling/reservoir_items_sketch.go:
##########
@@ -271,8 +312,15 @@ func (s *ReservoirItemsSketch[T])
insertValueAtPosition(item T, pos int) {
}
// forceIncrementItemsSeen adds delta to the items seen count.
-func (s *ReservoirItemsSketch[T]) forceIncrementItemsSeen(delta int64) {
+func (s *ReservoirItemsSketch[T]) forceIncrementItemsSeen(delta int64) error {
Review Comment:
You are right. I was wrong. chaning state first is correct. sketch's state
is gone wrong already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
