proost commented on code in PR #120:
URL: https://github.com/apache/datasketches-go/pull/120#discussion_r2780594125
##########
sampling/reservoir_items_sketch.go:
##########
@@ -44,11 +42,27 @@ const (
defaultResizeFactor = ResizeX8
minK = 2
+ maxItemsSeen = int64(0xFFFFFFFFFFFF)
// smallest sampling array allocated: 16
minLgArrItems = 4
)
+func resizeFactorLg(rf ResizeFactor) (int, error) {
Review Comment:
You can define ResizeFactor using iota. so, verbose `case` syntax doesn't
need.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
