tisonkun commented on issue #170: URL: https://github.com/apache/datasketches-rust/issues/170#issuecomment-5105981586
@proost Thanks for your information! Comments inline. > I think implementing the snapshot generation code itself is relatively straightforward. The more difficult part for a first-time contributor is figuring out which cases need to be covered and why. That usually requires understanding the sketch's internal, serialization format, and the cases that may affect cross-language compatibility. Agree. Could you share the code location or a link to the snapshot generation code? I'm going to make a go generator like [the cpp generator](https://github.com/apache/datasketches-tck/blob/main/serialization/cpp/generator.py) to check in Go snapshots in the datasketches-tck repo so that they can be used in any other datasketches impls. > However, datasketches-rust has not released v1.0.0 yet, so I think it is reasonable to be somewhat less strict during the pre-1.0 development phase. User and community understand that point :) What do you mean in this sentence? I don't get your point and it seems unrelated to other parts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
