proost commented on issue #170: URL: https://github.com/apache/datasketches-rust/issues/170#issuecomment-5106290004
> Agree. Could you share the code location or a link to the snapshot generation code? In each sketches, there is a serialization test file. And that file, generating snapshot code is included. For example, [theta sketch](https://github.com/apache/datasketches-go/blob/main/theta/sketch_serialization_test.go#L36). > What do you mean in this sentence? I don't get your point and it seems unrelated to other parts. Sorry, I phrased that poorly. I was only qualifying my earlier statement that all compatibility work should be completed before the first release containing the serialization/deserialization support. Since datasketches-rust is still pre-1.0, even if serialization code is released and we later discover through additional cross-language tests that the format is incorrect, we still have more room to fix it with a breaking change. The backward compatibility commitment is not as strong as it would be after 1.0.0. (Of course, more stricter is better). > And we did find several serde compatibility issues and got them fixed. do those issues include C++ or Java code too? or rust only? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
