Copilot commented on code in PR #189:
URL: https://github.com/apache/datasketches-rust/pull/189#discussion_r3744453335
##########
datasketches/tests/serde_tests/theta.rs:
##########
@@ -26,6 +28,24 @@ use googletest::prelude::near;
use crate::serialization_test_data;
+fn serialize_v2_exact(entries: &[u64]) -> Vec<u8> {
+ let current = ThetaSketchBuilder::default().build().compact(true);
+ let current_bytes = current.serialize();
+ let mut bytes = SketchBytes::with_capacity((2 + entries.len()) *
size_of::<u64>());
+ bytes.write_u8(2); // preamble longs
Review Comment:
`size_of::<u64>()` is used but not imported/qualified, so this test file
won’t compile. Either import `std::mem::size_of` or fully qualify the call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
