tisonkun commented on code in PR #189:
URL: https://github.com/apache/datasketches-rust/pull/189#discussion_r3744818341
##########
datasketches/tests/serde_tests/theta.rs:
##########
@@ -26,6 +28,24 @@ use googletest::prelude::near;
use crate::serialization_test_data;
+fn serialize_v2_exact(entries: &[u64]) -> Vec<u8> {
Review Comment:
> v2 serialize snapshot
Maybe. But existing C++/Java/Go impls do not provide one. We may provide one
when implementing #176 , and if you'd like to, you can go to other impls to ask
them to provide one and update https://github.com/apache/datasketches-tck.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
