jeffoodchain commented on code in PR #221:
URL: https://github.com/apache/datasketches-rust/pull/221#discussion_r3851623114
##########
datasketches/src/req/sketch.rs:
##########
Review Comment:
I think there are some `Error::invalid_argument` needed to change to
`Error::deserial` in this function.
##########
datasketches/src/req/sketch.rs:
##########
@@ -716,6 +729,19 @@ impl<T: ReqValue> ReqSketch<T> {
// --- Internal ---
+ fn retained_weighted_count(compactors: &[Compactor<T>]) -> Result<u64,
Error> {
Review Comment:
I think maybe no need to extract this as a function since it is only used
once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
