tisonkun commented on PR #221: URL: https://github.com/apache/datasketches-rust/pull/221#issuecomment-5412347968
@cestercian I found and fixed one additional malformed-state path after the previous review: two individually accepted high compactor states could OR to `u64::MAX` during merge and then overflow on compaction. The updated validation requires each compactor's history to fit within the serialized stream length (`state * 2 * level_weight <= n`, using checked arithmetic). This follows because every level compaction consumes at least two items at that level's weight, and `a | b <= a + b` preserves the bound across merges. The tests include both a finite inconsistent state and the complementary-state merge reproducer. I also ran a fresh defect-first review of the complete merge diff against the C++/Java section-growth logic and found no remaining actionable issues. Could you review the latest diff end to end and flag any concerns or alternatives? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
