SethFalco commented on code in PR #109:
URL: https://github.com/apache/deltaspike/pull/109#discussion_r1476738569
##########
deltaspike/core/impl/src/main/java/org/apache/deltaspike/core/impl/config/TypedResolverImpl.java:
##########
@@ -504,6 +530,66 @@ else if (Double.class.equals(configEntryType))
{
result = Double.parseDouble(value);
}
+ else if (Character.class.equals(configEntryType))
Review Comment:
Ahh, right this makes a little more sense to me now.
> we likely don't want awt package to be loaded there because there is a
security manager or javaagent for example
I've at least handled this part.
For now, the existing converters (primitives) are all supported out of the
box, while the new proposed converters can be loaded on demand with a producer.
```java
@Produces
public static PatternConverter getPatternConverter() {
return new PatternConverter();
}
```
I'm now able to use DeltaSpike + these converters as I'd expect when
imported into another project.
> provide a Map<Class, Converter> to the resolver
Could I make you elaborate on this part? Unfortunately, I did try to look
around the configuration extension, but wasn't sure how to apply this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@deltaspike.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
