rmannibucau commented on code in PR #109: URL: https://github.com/apache/deltaspike/pull/109#discussion_r1477052322
########## documentation/src/main/asciidoc/configuration.adoc: ########## @@ -203,7 +203,33 @@ Integer dbPort = ConfigResolver ==== Supported types -The types supported out of the box include: String, Integer, Long, Float, Double, Boolean, Class. +This table shows the types supported by Deltaspike already: Review Comment: On the type list I don't get all the choices (ex: why file and not path, why instant but not offsetdatetime which are more human friendly) but not a big blocker but the doc should document how to use it since as this DeltaSpike does *not* support the new type, it enables to use them if you do the work in your app - this is why I thought they should be matched in the extension and enabled implicitly ifuser didn't registered a custom producer (converter bean actually). That's the big picture for me, minimum there: ensure the doc explains how to use this feature and flag in the table the manual converter as such vs the implicit ones (primitive wrappers, string, class). rest is good for me hope it makes sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@deltaspike.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
