Emmanuel Lecharny wrote: > On 6/3/10 10:51 PM, Stefan Seelmann wrote: >> Hi dev, >> >> another easy refactoring is to merge the modules jdbm-store and >> jdbm-partiton. >> > > +1. Which one will you keep ? jdbm-store ? > > To me, a partition is associated with a naming context, not with an > underlying store. That implies we should get rid of those XXX-partition > to just keep xxx-store, and keep the partitions at a upper layer (ie, core)
I wanted to keep the jdbm-partition module. To me the partition is the concept that the core knows. The core knows nothing about stores. We also define partitions in the configuration, not stores. This is how I understand the architecture: 1. The core defines the Partition interface 2. XDBM provides an abstract implemementation of the Partition interface and additionally defines the Store interface and search engine. 3. The JDBM partition is a concrete implementation of the XDBM partition. It contains a Store implementation because this is forced by XDBM. Kind Regards, Stefan
