[X] +1 Release Shared 1.0.0-M1 and JUnit Add-ons 0.1
I checked the source and binary distribution packages. The sources package looks good and built successfully via Maven. I was able to connect to ApacheDS via the libraries included in the binary distribution package and small hand-written class (written in less than a minute :) ). Now, a few points that need discussion and can probably be improved in the next milestone release: - I'm not sure the NOTICE file is completely OK and probably needs to contain a small text entry for each third party library. - It may be interesting to use the Felix Bundle Maven plugin to make the 'shared-all' a real OSGI-ready bundle (It's a simple jar ATM). - It would be also interesting to bundle with the distribution the log4j dependency, just like we do for ApacheDS. I had to download this aside and add it to the build path to be able to work with the LDAP API. I understand that we're using a logging "façade" (SLF4J) to allow the user to choose the implementation he prefers, but I think most users of the API won't know and don't care about it. If we bundle log4j in the final distribution, the LDAP API can be used in one simple step and people willing to use their logger implementation of choice can easily remove the bundle log4j and add their own jar. Beside these three small remarks, the release looks really good. Congrats and thanks for handling this, Stefan! Regards Pierre-Arnaud On lundi 14 février 2011 at 10:22, Stefan Seelmann wrote: > Hi, > > This is a vote for the first milestone release on our way to a Shared > and LDAP API 1.0. Lot of cleanup and decoupling has already be done. > Also bug fixes and improvements have been done. Please see the release > notes below. > > The SVN tag: > http://svn.apache.org/repos/asf/directory/shared/tags/1.0.0-M1/ > > The source and binary distribution packages: > http://people.apache.org/~seelmann/shared-1.0.0-M1/ > The file names are prefixed with 'apache-ldap-api'. The bin packages > contain the shaded shared-all and all required dependencies to use the > LDAP API. > > The staging repository: > https://repository.apache.org/content/repositories/orgapachedirectory-062/ > > The generated site: > http://directory.apache.org/shared/gen-docs/1.0.0-M1/ > > > This is also a vote for JUnit Add-ons 0.1. This artifact is used by > Shared (and ApacheDS) for concurrency tests. Unfortunately the > artifacts are already published to the Maven repositories, so this > vote is to legitimate this after the fact. > > The SVN tag: > http://svn.apache.org/repos/asf/directory/buildtools/junit-addons/tags/0.1/ > > The artifacts in Maven repository: > http://repo1.maven.org/maven2/org/apache/directory/junit/junit-addons/0.1/ > > > Please cast your votes: > [ ] +1 Release Shared 1.0.0-M1 and JUnit Add-ons 0.1 > [ ] 0 abstain > [ ] -1 Do not release Shared 1.0.0-M1 and JUnit Add-ons 0.1 > > Kind Regards, > Stefan > > ------------------------------------------------------ > > Release Notes - Directory Shared - Version 1.0-M1 > > ** Sub-task > * [DIRSHARED-81] - Move classes and tests to appropriate area > * [DIRSHARED-82] - Adhere to package and class naming conventions > * [DIRSHARED-83] - Add documentation and test coverage > > ** Bug > * [DIRSHARED-4] - RDN length and start fields are not set > * [DIRSHARED-36] - Attribute type description schema parser uses > integer for syntax length, should be BigInteger > * [DIRSHARED-40] - DN parser, LdapDN, Rdn, Atav issues > * [DIRSHARED-58] - Interface > org.apache.directory.shared.ldap.cursor.Cursor isn't complete > * [DIRSHARED-60] - Equality matching rule is not required for an > attribute type description > * [DIRSHARED-63] - LDIFEntry does not handle controls > * [DIRSHARED-68] - schema extensions are not correctly parsed > * [DIRSHARED-69] - To string on a Filter throws NPE on toString() > * [DIRSHARED-71] - SearchResultEntryDsml does not use the provided > name of the attribute type > * [DIRSHARED-72] - DnNode does not handle move and rename operations > * [DIRSHARED-75] - AbstractSchemaLoader fails to add schema > objects if the schema name is given in capital letters > > ** Improvement > * [DIRSHARED-11] - Relax the ACI grammar parser > * [DIRSHARED-34] - LdifEntry.toString() should print LDIF rather > than diagnostic information > * [DIRSHARED-61] - Cleaning LdapMessage classes > * [DIRSHARED-64] - IStates and inherited interfaces/implementing > classes shpuld be enums > * [DIRSHARED-65] - Enabling a disabled schema should also enable > any disabled schemas the current schema depends on > > ** New Feature > * [DIRSHARED-28] - Need a feature like toString but different > > ** Task > * [DIRSHARED-46] - The LdapDN.toString() method should use the UP > name, not the normNane > * [DIRSHARED-50] - Rename DN methods to reflect the Client API decisions > * [DIRSHARED-54] - Replace all the JNDI exceptions with our own > exceptions (API) > * [DIRSHARED-59] - Replace public static finals by enums > * [DIRSHARED-79] - Control factories must be minimalistic - > presently they have too many needless methods. > * [DIRSHARED-80] - M1-STAGE-1: General cleanup master task >
