PersonnelRecordTest is indeed failing due to changes in Asn1CollectionType.java in the patch. Unfortunately we can't simply roll back the changes because the changes were made to address a problem with the decoding logic which resulted in adding default or empty values to the decoded object when fields were missing in the encoded data stream. This is incorrect behavior. Additional changes will be necessary to this class to correct the induced problem.
On Wed, Mar 30, 2016 at 9:44 PM, Jiajia Li (JIRA) <j...@apache.org> wrote: > > [ > https://issues.apache.org/jira/browse/DIRKRB-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15219187#comment-15219187 > ] > > Jiajia Li commented on DIRKRB-542: > ---------------------------------- > > [~gg], thanks for your contribution, I think it will be new achievement > for Kerby. > Some issues: > 1. After applying the patch to trunk, with some tests > failure(PersonnelRecordTest, SignedDataTest...) > 2. Compilation failure(ADAuthenticationIndicators.java) > 3. The patch reformatted some original code, then some lines are longer > than 80 characters(ps: Each line should not exceed 80) > 4. A lot of " @SuppressWarnings("unchecked")" were added in the patch, I > think some of them can be removed. > > > Kerby Authorization > > ------------------- > > > > Key: DIRKRB-542 > > URL: https://issues.apache.org/jira/browse/DIRKRB-542 > > Project: Directory Kerberos > > Issue Type: Sub-task > > Reporter: Gerard Gagliano > > Assignee: Gerard Gagliano > > Attachments: ad.patch > > > > > > Kerby lacks Authorization classes. Authorization types from RFC 1510, > 4120, 4537, 4556, 6711 and 7751 will greatly enhance the usability of Kerby. > > > > -- > This message was sent by Atlassian JIRA > (v6.3.4#6332) > -- Richard M Feezel rfee...@gmail.com
