[
https://issues.apache.org/jira/browse/DIRKRB-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15221092#comment-15221092
]
Jiajia Li commented on DIRKRB-542:
----------------------------------
Great work, no tests failure and check style issues now.
If you can do the following things, I think the patch will look better:
1. Some original code is reformatted, that will affect the logical expression
of patch. For example, actually no changes are in this "Asn1Simple.java" except
the format.
2. Can you provide some RFC definition in ASN1 classes? I found the
implementations of AuthenticationIndicator.java and
AuthenticationIndicators.java are the same, is it right?
3. Every patch should include all the changes, so that we can apply the patch
only the latest one.
Please feel free to let me know if you need some help.
> Kerby Authorization
> -------------------
>
> Key: DIRKRB-542
> URL: https://issues.apache.org/jira/browse/DIRKRB-542
> Project: Directory Kerberos
> Issue Type: Sub-task
> Reporter: Gerard Gagliano
> Assignee: Gerard Gagliano
> Attachments: ad.patch, ad2.patch, ad3.patch
>
>
> Kerby lacks Authorization classes. Authorization types from RFC 1510, 4120,
> 4537, 4556, 6711 and 7751 will greatly enhance the usability of Kerby.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
