bdemers commented on code in PR #435:
URL: https://github.com/apache/directory-scimple/pull/435#discussion_r1419170038
##########
scim-core/src/main/java/org/apache/directory/scim/core/repository/PatchGenerator.java:
##########
@@ -205,6 +205,7 @@ private List<PatchOperation> createPatchOperations() throws
IllegalArgumentExcep
JsonNode node2 = objectMapper.valueToTree(resource);
nullEmptyLists(node2);
JsonNode differences = JsonDiff.asJson(node1, node2,
DiffFlags.dontNormalizeOpIntoMoveAndCopy());
+// JsonNode differences = JsonDiff.asJson(node1, node2,
EnumSet.of(DiffFlags.ADD_EXPLICIT_REMOVE_ADD_ON_REPLACE,
DiffFlags.OMIT_MOVE_OPERATION, DiffFlags.OMIT_COPY_OPERATION,
DiffFlags.ADD_ORIGINAL_VALUE_ON_REPLACE));
Review Comment:
I think we may need to change the flags used to generate the diffs.
If we do that, i assume some of the logic that maps the diff to a SCIM patch
request may need to change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org
