bdemers commented on code in PR #435:
URL: https://github.com/apache/directory-scimple/pull/435#discussion_r1419171006
##########
scim-core/src/main/java/org/apache/directory/scim/core/repository/PatchGenerator.java:
##########
@@ -305,7 +306,7 @@ private List<PatchOperation> handleAttributes(JsonNode
valueNode, PatchOperation
} else {
log.debug("Attribute: null doesn't implement TypedAttribute,
can't create ValueFilterExpression");
}
- valueFilterExpression = new AttributeComparisonExpression(new
AttributeReference("value"), CompareOperator.EQ, "?");
+ valueFilterExpression = new AttributeComparisonExpression(new
AttributeReference("value"), CompareOperator.EQ, valueNode.textValue());
Review Comment:
The bits were wrong `"?"`, but assuming there is always a simple value here
isn't right either
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org
For additional commands, e-mail: dev-h...@directory.apache.org
