trnguyencflt commented on code in PR #289: URL: https://github.com/apache/directory-server/pull/289#discussion_r2221629520
########## core/src/main/java/org/apache/directory/server/core/security/TlsKeyGenerator.java: ########## @@ -40,26 +54,20 @@ import java.security.spec.X509EncodedKeySpec; import java.util.Date; -import javax.security.auth.x500.X500Principal; - -import org.apache.directory.api.ldap.model.constants.SchemaConstants; -import org.apache.directory.api.ldap.model.entry.Attribute; -import org.apache.directory.api.ldap.model.entry.Entry; -import org.apache.directory.api.ldap.model.exception.LdapException; -import org.apache.directory.server.i18n.I18n; -import org.bouncycastle.jce.provider.BouncyCastleProvider; -import org.bouncycastle.x509.X509V1CertificateGenerator; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; - /** * Generates the default RSA key pair for the server. - * + * @see https://github.com/apache/directory-server/blob/2.0.0-M20/core/src/main/java/org/apache/directory/server/core/security/TlsKeyGenerator.java * @author <a href="mailto:dev@directory.apache.org";>Apache Directory Project</a> + * @author Farid Zakaria <fzaka...@confluent.io> */ -public class TlsKeyGenerator +@SuppressWarnings("all") +public final class TlsKeyGenerator Review Comment: Is there a reason to make this a final class? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@directory.apache.org For additional commands, e-mail: dev-h...@directory.apache.org
