fzakaria commented on code in PR #289:
URL: https://github.com/apache/directory-server/pull/289#discussion_r2223780610
##########
pom.xml:
##########
@@ -162,8 +163,8 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
- <source>1.7</source>
- <target>1.7</target>
+ <source>1.8</source>
Review Comment:
I couldn't compile any more unless this was set.
1.7 is not supported on my JDK.. Authors can reject this part of the
contributions.
##########
core/src/main/java/org/apache/directory/server/core/security/TlsKeyGenerator.java:
##########
@@ -90,12 +98,13 @@ public class TlsKeyGenerator
*
* http://www.apache.org/licenses/exports
*/
- private static final int KEY_SIZE = 512;
+ private static final int KEY_SIZE = 1024;
Review Comment:
Yes FIPS requires 1024+ key size
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
