On Mon, Jan 9, 2017 at 8:00 PM, liang xie <xieliang...@gmail.com> wrote:
> Glad to see 0.4 will be release soon :)
> I could not find tutorials package from link[2], it should be released
> as well, please correct me if i am wrong.
>
I was thinking it might be necessary to release tutorials as a separated
bin package. since they are tutorials, people can download the src package
and build from there. A service binary package for deployment and a
benchmark binary package for benchmarking are probably enough.
But I am open to release tutorials as a separated binary package. Not sure
how does other apache project do. I'd like to see other people's opinions.
> I can pass this command with current git master code: "mvn clean
> apache-rat:check package findbugs:check -DskipTests", but failed with
> from distributedlog-0.4.0-incubating-src.tar.gz which downloaded from
> dist.apache.org, the error msg:
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-assembly-plugin:2.2.1:single (default)
> on project distributedlog-service: Failed to create assembly: Error
> adding file to archive:
> /tmp/distributedlog-0.4.0-incubating/distributedlog-service/../README.md
> isn't a file. -> [Help 1]
>
>
Ah, nice catch.
I think the src/assemble/bin.xml and src/assemble/src.xml have inconsistent
settings.
the bin.xml is looking for README.md
<file>
<source>../README.md</source>
<outputDirectory>/</outputDirectory>
<fileMode>644</fileMode>
</file>
however, the src.xml doesn't include README.md in the source package.
<includes>
<include>**/README</include>
> And none of you saw this : DL-181, it can be reproduced on my local
> box always w/o patched, weird...
>
>
I think I fixed that before. It is probably not pushed to master but in the
release branch. I merged your change to both master and
release-0.4.0-incubating branch. so it should be okay now.
> On Mon, Jan 9, 2017 at 12:04 PM, Sijie Guo <si...@apache.org> wrote:
> > Hi all,
> >
> > Please review and vote on the release candidate #1 for the version 0.4.0,
> > as follows:
> >
> > [ ] +1, Approve the release
> > [ ] -1, Do not approve the release (please provide specific comments)
> >
> > The complete staging area is available for your review, which includes:
> >
> > * JIRA release notes [1],
> > * the official Apache source release to be deployed to
> dist.apache.org
> > [2],
> > * all artifacts to be deployed to the Maven Central Repository [3],
> > * source code tag "v0.4.0-RC1" [4],
> > * website pull request listing the release [5] and publishing the API
> > reference manual.
> >
> > A simple instruction for validation the source and binary packages.
> >
> > - source package: run "*./scripts/integration/smoketest.sh*" after
> building
> > the package with "*mvn clean apache-rat:check package findbugs:check
> > -DskipTests*"
> >
> > The vote will be open for at least 72 hours. It is adopted by majority
> > approval, with at least 3 PPMC affirmative votes.
> >
> > Thanks,
> > Sijie
> >
> > [1]
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12320620&version=12337980
> > [2]
> > https://dist.apache.org/repos/dist/dev/incubator/distributedlog/0.4.0-
> incubating/
> > [3]
> > https://repository.apache.org/content/repositories/
> orgapachedistributedlog-1001/
> > [4]
> > https://github.com/apache/incubator-distributedlog/tree/
> v0.4.0-incubating-RC1
> > [5] https://github.com/apache/incubator-distributedlog/pull/109
>
