On Mon, Jan 9, 2017 at 5:32 PM, Sijie Guo <si...@apache.org> wrote: > Thank you for your suggestion, Khurrum. Comment inline. I'd like to > collect more feedbacks and then cut another RC. > > > On Mon, Jan 9, 2017 at 11:43 AM, Khurrum Nasim <khurrumnas...@gmail.com> > wrote: > >> Thanks Sijie for working on this. A couple of comments: >> >> - do we need to publish artifacts for both scala 2.10 and 2.11 (probably >> also 2.12)? as DL uses some scala libraries as the dependencies. >> > > Ah, ah, good catch. We need to publish both 2.10 and 2.11. > > >> - the source jar is also missing. do we need it? it is usually useful to >> have a source jar so that people who uses any IDE tool can easily navigate >> to the source code. >> > > It is a good suggestion. We don't have source maven plugin configured. We > need to configure that. >
Create https://issues.apache.org/jira/browse/DL-183 for generating the source jar. > > > > >> >> - KN >> >> On Sun, Jan 8, 2017 at 8:04 PM, Sijie Guo <si...@apache.org> wrote: >> >> > Hi all, >> > >> > Please review and vote on the release candidate #1 for the version >> 0.4.0, >> > as follows: >> > >> > [ ] +1, Approve the release >> > [ ] -1, Do not approve the release (please provide specific comments) >> > >> > The complete staging area is available for your review, which includes: >> > >> > * JIRA release notes [1], >> > * the official Apache source release to be deployed to >> dist.apache.org >> > [2], >> > * all artifacts to be deployed to the Maven Central Repository [3], >> > * source code tag "v0.4.0-RC1" [4], >> > * website pull request listing the release [5] and publishing the >> API >> > reference manual. >> > >> > A simple instruction for validation the source and binary packages. >> > >> > - source package: run "*./scripts/integration/smoketest.sh*" after >> > building >> > the package with "*mvn clean apache-rat:check package findbugs:check >> > -DskipTests*" >> > >> > The vote will be open for at least 72 hours. It is adopted by majority >> > approval, with at least 3 PPMC affirmative votes. >> > >> > Thanks, >> > Sijie >> > >> > [1] >> > https://issues.apache.org/jira/secure/ReleaseNote.jspa? >> > projectId=12320620&version=12337980 >> > [2] >> > https://dist.apache.org/repos/dist/dev/incubator/distributedlog/0.4.0- >> > incubating/ >> > [3] >> > https://repository.apache.org/content/repositories/ >> > orgapachedistributedlog-1001/ >> > [4] >> > https://github.com/apache/incubator-distributedlog/tree/ >> > v0.4.0-incubating-RC1 >> > [5] https://github.com/apache/incubator-distributedlog/pull/109 >> > >> > >
