I think we turned the log4j binding scope to test sometime ago. The thought was not to conflict bindings when DL is used as a library in other projects.
For binaries, it seems worth brining the bindings in. What does other projects do for slf4j bindings? Sijie On Jan 12, 2017 12:58 AM, "liang xie" <xieliang...@gmail.com> wrote: Verified source package with provided command and looks good to me. Seems missing slf4j-log4j12-1.6.4.jar in benchmark lib directory ? since i saw this error if execute "dbench write": SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder". SLF4J: Defaulting to no-operation (NOP) logger implementation SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details. On Wed, Jan 11, 2017 at 3:56 PM, Sijie Guo <si...@apache.org> wrote: > Hi all, > > Please review and vote on the release candidate #2 for the version 0.4.0, > as follows: > > [ ] +1, Approve the release > [ ] -1, Do not approve the release (please provide specific comments) > > The complete staging area is available for your review, which includes: > > * JIRA release notes [1], > * the official Apache source release to be deployed to dist.apache.org > [2], > * all artifacts to be deployed to the Maven Central Repository [3][4], > * source code tag "v0.4.0-incubating-RC1_2.11" (for scala 2.11) and > "v0.4.0-incubating-RC1_2.10" (for scala 2.10) [5][6], > * website pull request listing the release [7] and publishing the API > reference manual. > > A simple instruction for validation the source and binary packages. > > - source package: building the package with "*mvn clean apache-rat:check > package findbugs:check -DskipTests*" > > The vote will be open for at least 72 hours. It is adopted by majority > approval, with at least 3 PPMC affirmative votes. > > Thanks, > Sijie > > [1] https://issues.apache.org/jira/secure/ReleaseNote.jspa? > projectId=12320620&version=12337980 > [2] > https://dist.apache.org/repos/dist/dev/incubator/distributedlog/0.4.0- incubating-RC2/ > [3] > https://repository.apache.org/content/repositories/ orgapachedistributedlog-1003/ > [4] > https://repository.apache.org/content/repositories/ orgapachedistributedlog-1004/ > [5] > https://github.com/apache/incubator-distributedlog/tree/ v0.4.0-incubating-RC1_2.11 > [6] > https://github.com/apache/incubator-distributedlog/tree/ v0.4.0-incubating-RC1_2.10 > [7] https://github.com/apache/incubator-distributedlog/pull/109
