Hi Calvin, > Also, if you do this the python module in [2] will no longer be needed, since > you've released it separately.
I think is ok to separate python package, because is for eaiser download and convenience for python API user. Because we want to make python api release to PyPI[1] I find out is command in fink main tarball[2] and its Python API[3] and also spark main tarball[4] and its Python API[5]. So I think is OK to do that. > The source package in [1] lacks LICENSE And NOTICE Also I said above, the directory is a convenience source for PyPI, and all the LICENSE And NOTICE is in main tarball I also find out spark's Python API[5] withoutt LICENSE and NOTICE, and also flink’s Python API[3] without NOTICE and only with simple apache's LICENSE instead of list all LICENSEs in LICENSE file. > it's best to rename the filename to avoid misunderstandings Good catch, but the name we release to PyPI[1] is named `apache-dolphinscheduler`, my inital think is keep name in PyPI[1] is same as tarball’s name(and it should be). maybe we have to find a skill to avoid it. So, I think is only the rename filename problem left, Maybe we could try to fix it latter, WDYT? [1]: https://pypi.org/project/apache-dolphinscheduler/ <https://pypi.org/project/apache-dolphinscheduler/> [2]: https://dist.apache.org/repos/dist/release/flink/flink-1.14.3/flink-1.14.3-src.tgz <https://dist.apache.org/repos/dist/dev/flink/flink-1.14.4-rc1/python/apache-flink-1.14.4.tar.gz> [3]: https://dist.apache.org/repos/dist/release/flink/flink-1.14.3/python/apache-flink-1.14.4.tar.gz <https://dist.apache.org/repos/dist/dev/flink/flink-1.14.4-rc1/python/apache-flink-1.14.4.tar.gz> [4]: https://dist.apache.org/repos/dist/release/spark/spark-3.2.1/spark-3.2.1.tgz <https://dist.apache.org/repos/dist/release/spark/spark-3.2.1/spark-3.2.1.tgz> [5]: https://dist.apache.org/repos/dist/release/spark/spark-3.2.1/pyspark-3.2.1.tar.gz <https://dist.apache.org/repos/dist/release/spark/spark-3.2.1/pyspark-3.2.1.tar.gz> Cheers, — Jiajie Zhong > On Mar 3, 2022, at 01:10, CalvinKirs <[email protected]> wrote: > > -1 (binding) > > > The source package in [1] lacks LICENSE And NOTICE. > btw, if you're going to post this separately, it's best to rename the > filename to avoid misunderstandings. Also, if you do this the python module > in [2] will no longer be needed, since you've released it separately. > [1] > https://dist.apache.org/repos/dist/dev/dolphinscheduler/2.0.5/python/apache-dolphinscheduler-2.0.5.tar.gz > [2] > https://dist.apache.org/repos/dist/dev/dolphinscheduler/2.0.5/apache-dolphinscheduler-2.0.5-src.tar.gz > > > Best wishes！ > Calvin Kirs > > > On 03/2/2022 23:19，Jiajie Zhong<[email protected]> wrote： > +1 non-binding > > 1. download link correct > 2. sha512, asc checked > 3. LICENSE and NOTICE exist. > 5. all files have a license header > 6. compiling passed > > Well done and thanks Jiny > > Cheers, > — Jiajie Zhong > > On Mar 2, 2022, at 23:16, jiny.li <[email protected]> wrote: > > Hello DolphinScheduler Community, > > > This is a call for vote to release Apache DolphinScheduler version 2.0.5 > > > Release changes: > https://github.com/apache/dolphinscheduler/milestone/25 > > > The release candidates: > https://dist.apache.org/repos/dist/dev/dolphinscheduler/2.0.5/ > > > Maven 2 staging repository: > https://repository.apache.org/content/repositories/orgapachedolphinscheduler-1089/org/apache/dolphinscheduler/ > > > Git tag for the release: > https://github.com/apache/dolphinscheduler/tree/2.0.5 > > > Release Commit ID: > https://github.com/apache/dolphinscheduler/commit/f31328276c12821c21d1ce07e824bc74146c19b2 > > > Keys to verify the Release Candidate: > https://dist.apache.org/repos/dist/dev/dolphinscheduler/KEYS > > Look at here for how to verify this release candidate: > https://dolphinscheduler.apache.org/en-us/community/release.html > > > The vote will be open for at least 72 hours or until necessary number of > votes are reached. > > > Please vote accordingly: > > > [ ] +1 approve > > > [ ] +0 no opinion > > > [ ] -1 disapprove with the reason > > > Checklist for reference: > > > [ ] Download links are valid. > > > [ ] Checksums and PGP signatures are valid. > > > [ ] Source code artifacts have correct names matching the current release. > > > [ ] LICENSE and NOTICE files are correct for each DolphinScheduler repo. > > > [ ] All files have license headers if necessary. > > > [ ] No compiled archives bundled in source archive. > > > > > > > ——————————— > Apache DolphinScheduler Committer > JinYong Li 李进勇 > [email protected] >
