+1 I can't agree more
Best Regards --------------- Apache DolphinScheduler PMC Chair & Apache SeaTunnel PPMC Lidong Dai [email protected] Linkedin: https://www.linkedin.com/in/dailidong Twitter: @WorkflowEasy <https://twitter.com/WorkflowEasy> --------------- On Tue, Mar 8, 2022 at 11:52 AM Jiajie Zhong <[email protected]> wrote: > Hi ShunFeng, > > I think we should not merge pull requests when documents are lacking. > > IMO, source code, tests, docs are equally important. We do not merge > pull requests when tests missing or fail. So we also should not merge > pull requests missing docs or do not change related docs but they don't > > On Tue, Mar 8, 2022 at 11:24 AM ShunFeng Cai <[email protected]> > wrote: > > > Great, then we can keep the code and doc consistent. > > BTW, do we limit merging pr if doc is needed but lacking? > > > > -- > > Best Wish > > — Shunfeng > > > > Jiajie Zhong <[email protected]> 于2022年3月7日周一 19:30写道： > > > > > Hey guys, > > > > > > I proposal we should migrate our document from repo > > > dolphinscheduler-website[1] > > > to repo dolphinscheduler[2] for easier maintenance documentation. > > > > > > Currently we find out some of our documents is missing. And with > separate > > > repository, the missing documents would be much more when developers > > > submit PR to [2] but for forget to submit PR for [1]. And we could > solve > > it > > > methodologically by migrate document repo[1] to main[2]. > > > > > > Months ago I had sent a discuss in mail thread[3]. But we did not > reach a > > > consensus. > > > But I hope this time we should be together and find out some way to > > migrate > > > docs to main repo[2] > > > > > > [1]: https://github.com/apache/dolphinscheduler-website > > > [2]: https://github.com/apache/dolphinscheduler > > > [3]: https://lists.apache.org/thread/1l2cwvrcmr4rq8dgjcd11rxv51b6wc48 > > > > > > -- > > > Best Wish > > > — Jiajie > > > > > > > > -- > Best Wish > — Jiajie >
