Hi wenjun,

The size why so big of the repository dolphinscheduler-website it has
all version of docs, with all website base in it.

But we only migrate the latest version of the document to repository
dolphinscheduler. I think it would only be a litter space adding when we
migrate in such a way.

I would post the detailed plan about what would we do later before
We actually do this.

On Tue, Mar 8, 2022 at 10:28 PM Wenjun Ruan <[email protected]>
wrote:

> +1
>
> This will be helpful for maintaining documentation.
>
> There is one thing that may need attention, right now the
> dolphinscheduler-website repository is almost the same size as the
> dolphinscheduler code repository.
> This means after we merge these two repositories, the clone time will
> become twice as larger, but this time is acceptable for me at the
> moment.
>
> Thanks,
> Wenjun
>
> On Tue, Mar 8, 2022 at 9:52 PM Lidong Dai <[email protected]> wrote:
> >
> > +1  I can't agree more
> >
> >
> > Best Regards
> >
> >
> >
> > ---------------
> > Apache DolphinScheduler PMC Chair & Apache SeaTunnel PPMC
> > Lidong Dai
> > [email protected]
> > Linkedin: https://www.linkedin.com/in/dailidong
> > Twitter: @WorkflowEasy <https://twitter.com/WorkflowEasy>
> >
> > ---------------
> >
> >
> > On Tue, Mar 8, 2022 at 11:52 AM Jiajie Zhong <[email protected]>
> > wrote:
> >
> > > Hi ShunFeng,
> > >
> > > I think we should not merge pull requests when documents are lacking.
> > >
> > > IMO, source code, tests, docs are equally important. We do not merge
> > > pull requests when tests missing or fail. So we also should not merge
> > > pull requests missing docs or do not change related docs but they don't
> > >
> > > On Tue, Mar 8, 2022 at 11:24 AM ShunFeng Cai <
> [email protected]>
> > > wrote:
> > >
> > > > Great, then we can keep the code and doc consistent.
> > > > BTW, do we limit merging pr if doc is needed but lacking?
> > > >
> > > > --
> > > > Best Wish
> > > > — Shunfeng
> > > >
> > > > Jiajie Zhong <[email protected]> 于2022年3月7日周一 19:30写道:
> > > >
> > > > > Hey guys,
> > > > >
> > > > > I proposal we should migrate our document from repo
> > > > > dolphinscheduler-website[1]
> > > > > to repo dolphinscheduler[2] for easier maintenance documentation.
> > > > >
> > > > > Currently we find out some of our documents is missing. And with
> > > separate
> > > > > repository, the missing documents would be much more when
> developers
> > > > > submit PR to [2] but for forget to submit PR for [1]. And we could
> > > solve
> > > > it
> > > > > methodologically by migrate document repo[1] to main[2].
> > > > >
> > > > > Months ago I had sent a discuss in mail thread[3]. But we did not
> > > reach a
> > > > > consensus.
> > > > > But I hope this time we should be together and find out some way to
> > > > migrate
> > > > > docs to main repo[2]
> > > > >
> > > > > [1]: https://github.com/apache/dolphinscheduler-website
> > > > > [2]: https://github.com/apache/dolphinscheduler
> > > > > [3]:
> https://lists.apache.org/thread/1l2cwvrcmr4rq8dgjcd11rxv51b6wc48
> > > > >
> > > > > --
> > > > > Best Wish
> > > > > — Jiajie
> > > > >
> > > >
> > >
> > >
> > > --
> > > Best Wish
> > > — Jiajie
> > >
>


-- 
Best Wish
— Jiajie

Reply via email to