morningman commented on a change in pull request #368: Add a frontend interface
for committing RoutineLoadTask
URL: https://github.com/apache/incubator-doris/pull/368#discussion_r238513722
##########
File path:
fe/src/main/java/org/apache/doris/transaction/GlobalTransactionMgr.java
##########
@@ -766,6 +781,16 @@ private boolean checkTxnHasRelatedJob(TransactionState
txnState, Map<Long, Set<L
return true;
}
+ if (txnState.getSourceType() == LoadJobSourceType.ROUTINE_LOAD_TASK) {
+ try {
+ return
Catalog.getCurrentCatalog().getRoutineLoadInstance().getJobByTaskId(txnState.getLabel())
+ .checkTxnHasRelatedJob(txnState);
+ } catch (MetaNotFoundException e) {
+ // could not find job by task id while task has been deleted
Review comment:
If failed to failed job by task id, this should return false, i think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
