morningman commented on a change in pull request #368: Add a frontend interface
for committing RoutineLoadTask
URL: https://github.com/apache/incubator-doris/pull/368#discussion_r238512524
##########
File path:
fe/src/main/java/org/apache/doris/transaction/GlobalTransactionMgr.java
##########
@@ -356,10 +357,23 @@ public void commitTransaction(long dbId, long
transactionId, List<TabletCommitIn
// 6. update nextVersion because of the failure of persistent
transaction resulting in error version
updateCatalogAfterCommitted(transactionState, db);
LOG.info("transaction:[{}] successfully committed", transactionState);
+
+ // TODO: call updateCatalogAfterCommitted by transactionCallback
without if
+ if (transactionState.getSourceType() ==
LoadJobSourceType.ROUTINE_LOAD_TASK) {
+ try {
+
Catalog.getCurrentCatalog().getRoutineLoadInstance().getJobByTaskId(transactionState.getLabel())
+ .updateCatalogAfterCommitted(transactionState);
+ } catch (MetaNotFoundException e) {
+ LOG.error("failed to update routine load task {} after
committed txn {}",
Review comment:
use warning log level.
error level means the process should exit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
