chaoyli commented on a change in pull request #536: Add Rowset and
RowsetBuilder for PushHandler
URL: https://github.com/apache/incubator-doris/pull/536#discussion_r249741856
##########
File path: be/src/olap/push_handler.cpp
##########
@@ -330,69 +339,55 @@ OLAPStatus PushHandler::_convert(
}
}
- // 2. New SegmentGroup of curr_tablet for current push
- VLOG(3) << "init SegmentGroup.";
+ // 2. init RowsetBuilder of cur_tablet for current push
+ VLOG(3) << "init RowsetBuilder.";
if (_request.__isset.transaction_id) {
- // create pending data dir
- string dir_path = curr_tablet->construct_pending_data_dir_path();
- if (!check_dir_existed(dir_path) && (res = create_dirs(dir_path))
!= OLAP_SUCCESS) {
- if (!check_dir_existed(dir_path)) {
- OLAP_LOG_WARNING("fail to create pending dir. [res=%d
tablet=%s]",
- res, curr_tablet->full_name().c_str());
- break;
- }
- }
-
- delta_segment_group = new(std::nothrow) SegmentGroup(
- curr_tablet->tablet_id(),
- 0,
- curr_tablet->tablet_schema(),
- curr_tablet->num_key_fields(),
- curr_tablet->num_short_key_fields(),
- curr_tablet->num_rows_per_row_block(),
- curr_tablet->rowset_path_prefix(),
- (_request.push_type == TPushType::LOAD_DELETE),
- 0, 0, true, _request.partition_id, _request.transaction_id);
+ RowsetBuilderContextBuilder context_builder;
Review comment:
RowsetWriterContextBuilder
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
