chaoyli commented on a change in pull request #536: Add Rowset and
RowsetBuilder for PushHandler
URL: https://github.com/apache/incubator-doris/pull/536#discussion_r249742356
##########
File path: be/src/olap/delta_writer.cpp
##########
@@ -96,8 +97,13 @@ OLAPStatus DeltaWriter::init() {
}
}
- int32_t rowset_id = 0; // get rowset_id from id generator
- RowsetWriterContextBuilder context_builder;
+ RowsetId rowset_id = 0; // get rowset_id from id generator
+ OLAPStatus status =
RowsetIdGenerator::instance()->get_next_id(_tablet->data_dir(), &rowset_id);
+ if (status != OLAP_SUCCESS) {
+ LOG(WARNING) << "generate rowset id failed, status:" << status;
+ return OLAP_ERR_ROWSET_GENERATE_ID_FAILED;
+ }
+ RowsetBuilderContextBuilder context_builder;
Review comment:
Some interface has changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
