Hi, On 12/02/2014 04:06 PM, Jijiang Liu wrote: > Replace the inner_l2_len and the inner_l3_len field with the outer_l2_len and > outer_l3_len field, and rework csum forward engine and i40e PMD due to these > changes. > > Signed-off-by: Jijiang Liu <jijiang.liu at intel.com> > --- > app/test-pmd/csumonly.c | 58 > +++++++++++++++++++++------------------ > lib/librte_mbuf/rte_mbuf.h | 4 +- > lib/librte_pmd_i40e/i40e_rxtx.c | 38 +++++++++++++------------ > 3 files changed, 53 insertions(+), 47 deletions(-) >
Acked-by: Olivier Matz <olivier.matz at 6wind.com> One minor comment below: > @@ -303,8 +305,7 @@ process_outer_cksums(void *outer_l3_hdr, uint16_t > outer_ethertype, > * TESTPMD_TX_OFFLOAD_* in ports[tx_port].tx_ol_flags. They control > * wether a checksum must be calculated in software or in hardware. The > * IP, UDP, TCP and SCTP flags always concern the inner layer. The > - * VxLAN flag concerns the outer IP and UDP layer (if packet is > - * recognized as a vxlan packet). > + * VxLAN flag concerns the outer IP(if packet is recognized as a vxlan > packet). > */ > static void > pkt_burst_checksum_forward(struct fwd_stream *fs) Typo (no space before parenthesis) Regards, Olivier