On Thu, Dec 18, 2014 at 08:17:12AM -0800, Stephen Hemminger wrote: > On Wed, 17 Dec 2014 12:03:28 -0500 > Neil Horman <nhorman at tuxdriver.com> wrote: > > > Back in: > > > > commit aaa662e75c23c61a1d79bd4d1f9f35b4967c39db > > Author: Alan Carew <alan.carew at intel.com> > > Date: Fri Dec 5 15:19:07 2014 +0100 > > > > cmdline: fix overflow on bsd > > > > The author failed to fixup a call to cmdline_parse_etheraddr in xenvirt. > > This > > patch makes the needed correction to avoid a build break > > > > Signed-off-by: Neil Horman <nhorman at tuxdriver.com> > > CC: Thomas Monjalon <thomas.monjalon at 6wind.com> > > If we could fix the header incompatiablities then the driver could use > a standard library like ether_aton() instead of dragging in the unnecessary > cmdline library. > I agree, that would be great, but I think that would be better done after the release, since this is in compliance with how the rest of the DPDK handles this situation currently. Using ether_aton is definately a superior solution however.
Neil
