On 12/19/2014 4:54 AM, Neil Horman wrote: > On Thu, Dec 18, 2014 at 01:45:54PM +0000, Qiu, Michael wrote: >> Hi Neil, >> >> I think if you could add the commit author in the cc list will be better. >> > The commit author is me, and its recorded by the Signed-off line, as well as > the > Authorship tag in git. Not really sure what you're driving at here.
Sorry, What I mean "commit author" is who mentioned in you commit log, for this case should be this guy: alan.carew at intel.com I think. Sorry for I did not say it clearly. Yourself, of course, should be in the list. Thanks, Michael > >> Because this could let him know about his code's issue and he is the >> always the best person to review the patch. >> > Yes, Git already does that, as noted above. > > Neil > > >> Thanks, >> Michael >> >> On 2014/12/18 19:32, Neil Horman wrote: >>> Back in: >>> >>> commit aaa662e75c23c61a1d79bd4d1f9f35b4967c39db >>> Author: Alan Carew <alan.carew at intel.com> >>> Date: Fri Dec 5 15:19:07 2014 +0100 >>> >>> cmdline: fix overflow on bsd >>> >>> The author failed to fixup a call to cmdline_parse_etheraddr in xenvirt. >>> This >>> patch makes the needed correction to avoid a build break >>> >>> Signed-off-by: Neil Horman <nhorman at tuxdriver.com> >>> CC: Thomas Monjalon <thomas.monjalon at 6wind.com> >>> CC: Olivier Matz <olivier.matz at 6wind.com> >>> >>> --- >>> Change notes >>> >>> v2: Changed sizeof(struct ether_addr) to sizeof(dict->addr) >>> --- >>> lib/librte_pmd_xenvirt/rte_eth_xenvirt.c | 5 +++-- >>> 1 file changed, 3 insertions(+), 2 deletions(-) >>> >>> diff --git a/lib/librte_pmd_xenvirt/rte_eth_xenvirt.c >>> b/lib/librte_pmd_xenvirt/rte_eth_xenvirt.c >>> index 6555ec5..04e30c9 100644 >>> --- a/lib/librte_pmd_xenvirt/rte_eth_xenvirt.c >>> +++ b/lib/librte_pmd_xenvirt/rte_eth_xenvirt.c >>> @@ -586,8 +586,9 @@ rte_eth_xenvirt_parse_args(struct xenvirt_dict *dict, >>> if (!strncmp(pair[0], RTE_ETH_XENVIRT_MAC_PARAM, >>> sizeof(RTE_ETH_XENVIRT_MAC_PARAM))) { >>> if (cmdline_parse_etheraddr(NULL, >>> - pair[1], >>> - &dict->addr) < 0) { >>> + pair[1], >>> + &dict->addr, >>> + sizeof(dict->addr)) < 0) { >>> RTE_LOG(ERR, PMD, >>> "Invalid %s device ether address\n", >>> name); >>