Hi, > -----Original Message----- > From: Shreyansh Jain [mailto:[email protected]] > Sent: Wednesday, May 9, 2018 12:40 PM > To: De Lara Guarch, Pablo <[email protected]> > Cc: Akhil Goyal <[email protected]>; [email protected]; Hemant Agrawal > <[email protected]> > Subject: Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: remove iova conversion for > fle address > > On Wednesday 09 May 2018 03:54 PM, De Lara Guarch, Pablo wrote: > > > > > >> -----Original Message----- > >> From: Akhil Goyal [mailto:[email protected]] > >> Sent: Wednesday, May 9, 2018 10:14 AM > >> To: Shreyansh Jain <[email protected]>; De Lara Guarch, Pablo > >> <[email protected]> > >> Cc: [email protected]; [email protected]; Hemant Agrawal > >> <[email protected]> > >> Subject: Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: remove iova > >> conversion for fle address > >> > >> On 5/9/2018 2:56 PM, Shreyansh Jain wrote: > >>> From: Hemant Agrawal <[email protected]> > >>> > >>> fle is already in virtual addressing mode - no need to perform > >>> address conversion for it. > >>> > >>> Fixes: 8d1f3a5d751b ("crypto/dpaa2_sec: support crypto operation") > >>> Cc: [email protected] > >>> > >>> Signed-off-by: Hemant Agrawal <[email protected]> > > > > ... > > > >>> > >> Acked-by: Akhil Goyal <[email protected]> > > > > Added Cc: [email protected] (try remembering this for next time, please). > > Thanks for doing it this time. I'll take care of this next time.
No worries. Actually, gcc 32 bits is broken: drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c:1264:7: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] op = (struct rte_crypto_op *)DPAA2_GET_FLE_ADDR((fle - 1)); Is this PMD supposed to be compatible for 32-bit targets? Thanks, Pablo > > > > > Applied to dpdk-next-crypto. > > Thanks, > > > > Pablo > >
