2015-04-09 12:40, Ravi Kerur: > Changes in v5 > Rebase to latest code. > > Changes in v4 > Implement cpu_detected() for BSD. > Have common RTE_LOG for Linux and BSD in rte_eal_cpu_init(). > Remove RTE_EXEC_ENV_BSDAPP in common file. > > Changes in v3 > Changed subject to be more explicit on file name inclusion. > > Changes in v2 > None > > Changes in v1 > Move common function in eal_lcore.c to librte_eal/common/ > eal_common_lcore.c file. > > Following function is moved to eal_common_lcore.c file > > int rte_eal_cpu_init(void); > > Use RTE_EXEC_ENV_BSDAPP to differentiate minor differences in > common function. > Makefile changes to reflect new file added. > Fix checkpatch warnings and errors. > > Signed-off-by: Ravi Kerur <rkerur at gmail.com> [...] > --- a/lib/librte_eal/bsdapp/eal/eal_lcore.c > +++ b/lib/librte_eal/bsdapp/eal/eal_lcore.c [...] > static int > -get_ncpus(void) > +eal_get_ncpus(void)
Why not keep it static as it seems to be specific to BSD handling? > { > int mib[2] = {CTL_HW, HW_NCPU}; > int ncpu; > @@ -59,63 +62,18 @@ get_ncpus(void) > return ncpu; > } [...] > -unsigned > -eal_cpu_socket_id(__rte_unused unsigned cpu_id) > +/* Check if a cpu is present by the presence of the > + * cpu information for it. > + */ > +int > +eal_cpu_detected(unsigned lcore_id) > { > - return cpu_socket_id(cpu_id); > + const unsigned ncpus = eal_get_ncpus(); > + return (lcore_id < ncpus); > }