Thomas, Thanks for the review so far, I will make necessary changes and send out v6.
Thanks, Ravi On Thu, Apr 16, 2015 at 3:08 PM, Ravi Kerur <rkerur at gmail.com> wrote: > > > On Thu, Apr 16, 2015 at 1:24 AM, Thomas Monjalon < > thomas.monjalon at 6wind.com> wrote: > >> Hi Ravi, >> >> I think this patch is too complex and move too many different things: >> - sysfs >> - mem_cfg >> - proc_type >> - application_usage >> Please split them up. >> >> I'm not sure the classification in eal_common_runtime.c and >> eal_common_system.c >> new file is clear. >> > > I chose most system related functions (hugepages, lcore sockets, sysfs) > into eal_common_system.c file. Rest I moved them to eal_common_runtime.c > file for lack of better name. You want more fine grained control and divide > them into 4 files?? > >> >> 2015-04-09 12:40, Ravi Kerur: >> > + mem_config = (struct rte_mem_config *) mmap(NULL, >> sizeof(*mem_config), >> >> Why this cast is needed? >> > > Linux has it, BSD doesn't. I just chose Linux version. > >