> On Jan 11, 2019, at 12:06 PM, Stephen Hemminger <step...@networkplumber.org>
> wrote:
>
> The code for set_interface_name was incorrectly assuming that
> space for null byte was necessary with snprintf/strlcpy.
>
> Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD")
> Signed-off-by: Stephen Hemminger <step...@networkplumber.org>
> ---
> drivers/net/tap/rte_eth_tap.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
> index 1c00681ba0eb..d7f77d664502 100644
> --- a/drivers/net/tap/rte_eth_tap.c
> +++ b/drivers/net/tap/rte_eth_tap.c
> @@ -1892,10 +1892,10 @@ set_interface_name(const char *key __rte_unused,
> char *name = (char *)extra_args;
>
> if (value)
> - strlcpy(name, value, RTE_ETH_NAME_MAX_LEN - 1);
> + strlcpy(name, value, RTE_ETH_NAME_MAX_LEN);
> else
> - snprintf(name, RTE_ETH_NAME_MAX_LEN - 1, "%s%d",
> - DEFAULT_TAP_NAME, (tap_unit - 1));
> + snprintf(name, RTE_ETH_NAME_MAX_LEN, "%s%d",
> + DEFAULT_TAP_NAME, tun_unit - 1);
Was this meant to change from tap_unit to tun_unit here, if so why?
>
> return 0;
> }
> --
> 2.20.1
>
Regards,
Keith
