14/01/2019 15:58, Olivier Matz:
> On Fri, Jan 11, 2019 at 02:33:16PM +0000, Dumitrescu, Cristian wrote:
> > From: Van Haaren, Harry
> > >
> > > Although C compilation works with the struct rte_mbuf_sched
> > > declared inside the struct rte_mbuf namespace, C++ fails to
> > > compile. This fix moves the rte_mbuf_sched struct up to the
> > > global namespace, instead of declaring it inside the struct
> > > mbuf namespace.
> > >
> > > The struct rte_mbuf_sched is being used on the stack in
> > > rte_mbuf_sched_get() and as a cast in _set(). For this
> > > reason, it must be exposed as an available type.
> > >
> > > Fixes: 5d3f72100904 ("mbuf: implement generic format for sched field")
> > >
> > > Signed-off-by: Harry van Haaren <harry.van.haa...@intel.com>
> > >
> > > ---
> > >
> > > v3:
> > > - Update comment in mbuf to state size of struct sched (Crisitian)
> > >
> > > v2:
> > > - Different solution, not applicable, v3 based on v1 (ML discussion)
> >
> > Acked-by: Cristian Dumitrescu <cristian.dumitre...@intel.com>
> >
> > Of course, final say belongs to Olivier, so Olivier please let un know your
> > vote.
>
> Acked-by: Olivier Matz <olivier.m...@6wind.com>
Applied, thanks
