On Wed, Jan 30, 2019 at 11:15:44AM +0000, Ferruh Yigit wrote: > On 1/29/2019 8:41 PM, Thomas Monjalon wrote: > > 29/01/2019 16:30, Ferruh Yigit: > >> Fixes line commit id length defined as 12 in fixline alias: > >> fixline = log -1 --abbrev=12 --format='Fixes: %h (\"%s\")%nCc: %ae' > >> > >> Check if the Fixes line commit id length matches the defined value. > > > > This check was missing on purpose, in order to not be too strict. > > I think it's OK if the length of the SHA1 is not always the same. > > That is OK, if we don't want to be strict on this, I will update patch as > rejected. > I think having this check is still good. It's not enforcing the rule, just warning when violated. In 99% of cases this warning should be fixed IMHO, especially if you guys are fixing these manually anyway.
/Bruce
