On Wed, Jan 30, 2019 at 12:27:58PM +0100, Thomas Monjalon wrote: > 30/01/2019 12:17, Ferruh Yigit: > > On 1/30/2019 9:58 AM, David Marchand wrote: > > > The contributing guide does indicate you are supposed to run both > > > checkpatches.sh and check-git-log.sh. > > > I am pretty sure I missed this second step in the past.. > > > > > > How about calling check-git-log.sh from checkpatches.sh ? > > > check-git-log.sh does not support patch files as input, so it would need > > > support for it. > > > > That sounds good idea to have single script to run. > > It will never be only one script to run. > There are more scripts in devtools and I plan to add more. > Some checks can be done only once for a group of commits, > and will be really too slow if run for each patch when merging a branch. > > About check-git-log, some tests cannot be possible outside of a git tree. > Do you want to run it when checkpatches is run on git tree? > Wouldn't it be confusing? > Possibly, but we can print out a warning when not run, saying "check-git-log skipped because we are not running on git tree". I think the benefit of having all checks done by one script is greater than the downside of a little confusion.
/Bruce
