Hi Fiona,
Sorry for delay in response. Please see inline. Thanks and regards Ayuj Verma ________________________________ From: Trahe, Fiona <[email protected]> Sent: 12 April 2019 20:47 To: Ayuj Verma; [email protected]; Kusztal, ArkadiuszX Cc: Shally Verma; Sunila Sahu; Kanaka Durga Kotamarthy; Arvind Desai; [email protected]; Trahe, Fiona Subject: RE: [PATCH v1] fix alphabetical ordering of headers Hi Ayuj, > -----Original Message----- > From: Ayuj Verma [mailto:[email protected]] > Sent: Friday, April 12, 2019 8:03 AM > To: [email protected]; Kusztal, ArkadiuszX <[email protected]>; > Trahe, Fiona > <[email protected]> > Cc: [email protected]; [email protected]; [email protected]; > [email protected]; > [email protected]; Ayuj Verma <[email protected]> > Subject: [PATCH v1] fix alphabetical ordering of headers > > rte_crypto_sym.h is included prior to rte_crypto_asym.h > in rte_crypto.h, which breaks alphabetical order. > > include rte_crypto_sym.h in rte_crypto_asym.h fixes this. [Fiona] I presume you tried just swapping the order and it broke? If something in rte_crypto_asym.h depends on something from rte_crypto_sym.h, it probably shouldn't. What's the dependency and can/should it be moved to rte_crypto.h? [Ayuj] it is enum rte_crypto_auth_algorithm which it import from sym.h. So do you suggest to move it to rte_crypto.h?
