Hi Ayuj, Akhil, From: Akhil Goyal [mailto:[email protected]] Sent: Wednesday, April 17, 2019 10:58 AM To: Ayuj Verma <[email protected]>; Trahe, Fiona <[email protected]>; Kusztal, ArkadiuszX <[email protected]> Cc: Shally Verma <[email protected]>; Sunila Sahu <[email protected]>; Kanaka Durga Kotamarthy <[email protected]>; Arvind Desai <[email protected]>; [email protected] Subject: Re: [PATCH v1] fix alphabetical ordering of headers
Hi Ayuj, > -----Original Message----- > From: Ayuj Verma [mailto:[email protected]] > Sent: Friday, April 12, 2019 8:03 AM > To: [email protected]<mailto:[email protected]>; Kusztal, ArkadiuszX > <[email protected]<mailto:[email protected]>>; Trahe, > Fiona > <[email protected]<mailto:[email protected]>> > Cc: [email protected]<mailto:[email protected]>; > [email protected]<mailto:[email protected]>; > [email protected]<mailto:[email protected]>; > [email protected]<mailto:[email protected]>; > [email protected]<mailto:[email protected]>; Ayuj Verma > <[email protected]<mailto:[email protected]>> > Subject: [PATCH v1] fix alphabetical ordering of headers > > rte_crypto_sym.h is included prior to rte_crypto_asym.h > in rte_crypto.h, which breaks alphabetical order. > > include rte_crypto_sym.h in rte_crypto_asym.h fixes this. [Fiona] I presume you tried just swapping the order and it broke? If something in rte_crypto_asym.h depends on something from rte_crypto_sym.h, it probably shouldn't. What's the dependency and can/should it be moved to rte_crypto.h? [Ayuj] it is enum rte_crypto_auth_algorithm which it import from sym.h. So do you suggest to move it to rte_crypto.h? [Akhil] moving the enum is not a good idea. I believe we do not need this change at all. Keeping the headers in alphabetical order may be a preferred way, But it should not be mandatory, there may be some dependencies like this. [Fiona] I agree with not moving the enum, now that I understand the dependency. Either no change or the original patch are fine with me.
