> -----Original Message-----
> From: Anoob Joseph <[email protected]>
> Sent: Monday, June 3, 2019 11:02 PM
> To: Jerin Jacob Kollanukkaran <[email protected]>; Nikhil Rao
> <[email protected]>; Erik Gabriel Carrillo <[email protected]>;
> Abhinandan Gujjar <[email protected]>; Bruce Richardson
> <[email protected]>; Pablo de Lara
> <[email protected]>
> Cc: Anoob Joseph <[email protected]>; Narayana Prasad Raju Athreya
> <[email protected]>; [email protected]; Lukas Bartosik
> <[email protected]>; Pavan Nikhilesh Bhagavatula
> <[email protected]>; Hemant Agrawal
> <[email protected]>; Nipun Gupta <[email protected]>; Harry
> van Haaren <[email protected]>; Mattias Rönnblom
> <[email protected]>; Liang Ma <[email protected]>
> Subject: [PATCH 14/39] eventdev: add files for eventmode helper
>
> Adding files for eventmode helper
>
> Signed-off-by: Anoob Joseph <[email protected]>
> Signed-off-by: Lukasz Bartosik <[email protected]>
> ---
> lib/librte_eventdev/Makefile | 5 +++--
> lib/librte_eventdev/meson.build | 2 ++
> lib/librte_eventdev/rte_eventmode_helper.c | 7 +++++++
> lib/librte_eventdev/rte_eventmode_helper.h | 15 +++++++++++++++
s/rte_eventmode_helper/rte_event_helper/gc. See below
> lib/librte_eventdev/rte_eventmode_helper_internal.h | 6 ++++++
> 5 files changed, 33 insertions(+), 2 deletions(-) create mode 100644
> lib/librte_eventdev/rte_eventmode_helper.c
> +#ifndef _RTE_EVENTMODE_HELPER_H_
> +#define _RTE_EVENTMODE_HELPER_H_
In order to shortened the macros, enums, APIs, I think,
We can change to rte_event_helper from rte_eventmode_here.
> +
> +#ifdef __cplusplus
> +extern "C" {
> +#endif
> +
> +#ifdef __cplusplus
> +}
> +#endif
> +
> +#endif /* _RTE_EVENTMODE_HELPER_H_ */
> diff --git a/lib/librte_eventdev/rte_eventmode_helper_internal.h
> b/lib/librte_eventdev/rte_eventmode_helper_internal.h
> new file mode 100644
> index 0000000..0da7003
> --- /dev/null
> +++ b/lib/librte_eventdev/rte_eventmode_helper_internal.h
> @@ -0,0 +1,6 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright (C) 2019 Marvell International Ltd.
> + */
> +#ifndef _RTE_EVENTMODE_HELPER_INTERNAL_H_ #define
Please have this patch for Helper API definition(spec) and remaining patches
for implementation. That would help contract between helper and application.
> +_RTE_EVENTMODE_HELPER_INTERNAL_H_
> +#endif /* _RTE_EVENTMODE_HELPER_INTERNAL_H_ */
> --
> 2.7.4
