> -----Original Message-----
> From: Anoob Joseph <[email protected]>
> Sent: Monday, June 3, 2019 11:02 PM
> To: Jerin Jacob Kollanukkaran <[email protected]>; Nikhil Rao
> <[email protected]>; Erik Gabriel Carrillo <[email protected]>;
> Abhinandan Gujjar <[email protected]>; Bruce Richardson
> <[email protected]>; Pablo de Lara
> <[email protected]>
> Cc: Anoob Joseph <[email protected]>; Narayana Prasad Raju Athreya
> <[email protected]>; [email protected]; Lukas Bartosik
> <[email protected]>; Pavan Nikhilesh Bhagavatula
> <[email protected]>; Hemant Agrawal
> <[email protected]>; Nipun Gupta <[email protected]>; Harry
> van Haaren <[email protected]>; Mattias Rönnblom
> <[email protected]>; Liang Ma <[email protected]>
> Subject: [PATCH 16/39] eventdev: add eventmode CL options framework
>
> Adding usage prints and CL parsing routines for eventmode. Option to select
> packet transfer mode is also added.
>
> Signed-off-by: Anoob Joseph <[email protected]>
> Signed-off-by: Lukasz Bartosik <[email protected]>
> ---
> +#include <rte_compat.h>
> +
> +/* Packet transfer mode of the application */ enum
> +rte_eventmode_helper_pkt_transfer_mode {
> + RTE_EVENTMODE_HELPER_PKT_TRANSFER_MODE_POLL = 0,
> + RTE_EVENTMODE_HELPER_PKT_TRANSFER_MODE_EVENT,
> +};
Need to mark all public structues as EXPERIMENTAL.
Please grep for EXPERIMENTAL in libeventdev or any other library
> +struct rte_eventmode_helper_conf {
> + enum rte_eventmode_helper_pkt_transfer_mode mode;
> + /**< Packet transfer mode of the application */
> + void *mode_params;
> + /**< Mode specific parameters */
> +};
Please make this event_helper object as 'opaque' and move to internal so that
it does have
ABI policies and future new features can be added.